Followup on migration from groovy pt13 - #12314
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoAug 28, 2026
Merged
Conversation
add @VisiableforTesting on aggregates methods add static import of Collections class created a helper method for ClientStatsAggregator instantiation add timeout on CountDownLatch Use @tempdir to create a temp dir for creating rules file
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
jpbempel
added
comp: testing
![datadog-official[bot]](https://avatars.githubusercontent.com/in/1358509?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
More details
The helper methods keep the same constructor values. The timeout and temporary test directory do not change product behavior.
🤖 Datadog Autotest · Commit b156371 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
This comment has been minimized.
This comment has been minimized.
mhdatie
approved these changes
Aug 27, 2026
mhlidd
approved these changes
Aug 27, 2026
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 28, 2026
AlexeyKuznetsov-DD
approved these changes
Aug 28, 2026
gh-worker-dd-mergequeue-cf854d
Bot
merged commit Aug 28, 2026
fce1d93
into
master
603 of 609 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
jpbempel/followup-g2j-core-pt13
branch
August 28, 2026 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
add
@VisiableforTestingonaggregatesmethodsadd static import of
Collectionsclasscreated a helper method for
ClientStatsAggregatorinstantiation add timeout onCountDownLatchUse
@TempDirto create a temp dir for creating rules fileMotivation
Additional Notes
Follow-ups of #12253
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]